Skip to content

chore: typo fixes #2458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2025
Merged

chore: typo fixes #2458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7242001
chore: typo fixes
willmafh Oct 23, 2025
bdc6a4f
chore: typo fixes
willmafh Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/ngx_http_lua_ssl_certby.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ ngx_http_lua_ssl_cert_handler(ngx_ssl_conn_t *ssl_conn, void *data)

if (cctx->done) {
ngx_log_debug1(NGX_LOG_DEBUG_HTTP, c->log, 0,
"lua_certificate_by_lua: cert cb exit code: %d",
"ssl_certificate_by_lua: cert cb exit code: %d",
cctx->exit_code);

dd("lua ssl cert done, finally");
Expand Down Expand Up @@ -319,7 +319,7 @@ ngx_http_lua_ssl_cert_handler(ngx_ssl_conn_t *ssl_conn, void *data)
}

ngx_log_debug2(NGX_LOG_DEBUG_HTTP, c->log, 0,
"lua_certificate_by_lua: handler return value: %i, "
"ssl_certificate_by_lua: handler return value: %i, "
"cert cb exit code: %d", rc, cctx->exit_code);

c->log->action = "SSL handshaking";
Expand Down Expand Up @@ -405,15 +405,15 @@ ngx_http_lua_ssl_cert_aborted(void *data)
{
ngx_http_lua_ssl_ctx_t *cctx = data;

dd("lua ssl cert done");
dd("lua ssl cert aborted");

if (cctx->done) {
/* completed successfully already */
return;
}

ngx_log_debug0(NGX_LOG_DEBUG_HTTP, cctx->connection->log, 0,
"lua_certificate_by_lua: cert cb aborted");
"ssl_certificate_by_lua: cert cb aborted");

cctx->aborted = 1;
cctx->request->connection->ssl = NULL;
Expand Down
2 changes: 1 addition & 1 deletion src/ngx_http_lua_ssl_session_fetchby.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ ngx_http_lua_ssl_sess_fetch_aborted(void *data)
{
ngx_http_lua_ssl_ctx_t *cctx = data;

dd("lua ssl sess_fetch done");
dd("lua ssl sess_fetch aborted");

if (cctx->done) {
/* completed successfully already */
Expand Down
8 changes: 4 additions & 4 deletions t/139-ssl-cert-by.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,7 @@ failed to do SSL handshake: handshake failed

--- error_log eval
[
'lua_certificate_by_lua: handler return value: -1, cert cb exit code: 0',
'ssl_certificate_by_lua: handler return value: -1, cert cb exit code: 0',
qr/(\[info\] .*? SSL_do_handshake\(\) failed .*?cert cb error|routines:OPENSSL_internal:CERT_CB_ERROR)/,
'lua exit with code -1',
]
Expand Down Expand Up @@ -723,7 +723,7 @@ failed to do SSL handshake: handshake failed

--- error_log eval
[
'lua_certificate_by_lua: cert cb exit code: 0',
'ssl_certificate_by_lua: cert cb exit code: 0',
qr/(\[info\] .*? SSL_do_handshake\(\) failed .*?cert cb error|routines:OPENSSL_internal:CERT_CB_ERROR)/,
'lua exit with code -1',
]
Expand Down Expand Up @@ -794,7 +794,7 @@ failed to do SSL handshake: handshake failed
--- error_log eval
[
'runtime error: ssl_certificate_by_lua(nginx.conf:28):2: bad bad bad',
'lua_certificate_by_lua: handler return value: 500, cert cb exit code: 0',
'ssl_certificate_by_lua: handler return value: 500, cert cb exit code: 0',
qr/(\[info\] .*? SSL_do_handshake\(\) failed .*?cert cb error|routines:OPENSSL_internal:CERT_CB_ERROR)/,
qr/context: ssl_certificate_by_lua\*, client: \d+\.\d+\.\d+\.\d+, server: \d+\.\d+\.\d+\.\d+:\d+/,
]
Expand Down Expand Up @@ -866,7 +866,7 @@ failed to do SSL handshake: handshake failed
--- error_log eval
[
'runtime error: ssl_certificate_by_lua(nginx.conf:28):3: bad bad bad',
'lua_certificate_by_lua: cert cb exit code: 0',
'ssl_certificate_by_lua: cert cb exit code: 0',
qr/(\[info\] .*? SSL_do_handshake\(\) failed .*?cert cb error|routines:OPENSSL_internal:CERT_CB_ERROR)/,
]

Expand Down
Loading