-
Notifications
You must be signed in to change notification settings - Fork 1
Added Configuration UI and REST Endpoints #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Notably test3 also includes changes from #30, but this doesn't change any of the functionality besides introducing protected endpoints/SSO auth |
MartinaeyNL
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've taken a look at your frontend code, and made a few remarks.
Feel free to check them out or ask for clarification 👍
Great work!
Changed `updated` lifecycle function calls to `willUpdate` to avoid double renders Adjusted tsconfig.json to be more align with what `lit` recommends for publishing Using `lit` directives instead of ternary operators Comment improvements Helper function for the api service to build the base url Updated todo with corresponding issue annotation Removed unnecessary div elements Removed unecessary state decorators
…n if necessary data couldnt be fetched
|
@MartinaeyNL Thanks for the review, appreciate it. I've addressed all the requested changes, feel free to take a look again when you have the chance. Re-requested the review :) |
|
I'll walk through the changes one more time. Give me a bit of time 😉 |
|
Made 1 comment on the Rspack dependency. When addressed, the PR is OK to merge 👍 |
Everything still works, testing the bulding, environment variables and serving

Closes #14
Closes #9
Summary
This PR introduces the following changes:
REST API
ModelConfig Management Endpoints
OpenRemote Utility Endpoints
UI Bundle Endpoint
ML_WEB_DIST_DIR/uiWeb UI Frontend
Note: Currently does not have localization! Still needs to be figured out how we want to handle this for services.
Tech Stack
Pages
Model Configs Overview
Model Config Editor
Bug Fixes
Other
ML_WEBSERVER_ORIGINSwas added to specify the allowed origins.Testing
Automated (Back-End)
Manual (Front-End)
Local Testing Instructions
I've updated the README.md with additional setup instructions.
Things to make sure of:
ML_OR_SERVICE_USERandML_OR_SERVICE_SECRETenvironment variables.You can also create a .env file in the root directory
And then just follow the README instructions for starting the back-end and front-end.
It is also deployed on
test3and is connected to the OR instance ontest3You can find it in the services page.