Skip to content

💪 Update RestfulApiRoutesBuilder#generateRendererHandler() with ResponseFlusher structure #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025
Merged

💪 Update RestfulApiRoutesBuilder#generateRendererHandler() with ResponseFlusher structure #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60effc6
Update test for RestfulApiRoutesBuilder#generateRendererHandler()
StewEucen Apr 25, 2025
0bfc507
Enhance RestfulApiRoutesBuilder#generateRendererHandler() with Respon…
StewEucen Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/server/restfulapi/RestfulApiRoutesBuilder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,9 @@ export default class RestfulApiRoutesBuilder {
expressRequest: req,
})

this.flushResponse({
renderer.flushResponse({
expressResponse: res,
response,
renderResponse: response,
})
}
}
Expand Down
10 changes: 7 additions & 3 deletions tests/__tests__/server/restfulapi/RestfulApiRoutesBuilder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,6 +605,9 @@ describe('RestfulApiRoutesBuilder', () => {
json () {
return this
},
set () {
return this
},
})

/** @type {ExpressType.NextFunction} */
Expand Down Expand Up @@ -658,7 +661,7 @@ describe('RestfulApiRoutesBuilder', () => {
})
})

describe('to call #flushResponse()', () => {
describe('to call Renderer#flushResponse()', () => {
describe.each(engineCases)('Engine: $params.Engine.name', ({ params }) => {
test.each(cases)('renderer: $renderer.constructor.name', async ({ renderer, filterHandler }) => {
const engine = await params.Engine.createAsync()
Expand All @@ -677,7 +680,8 @@ describe('RestfulApiRoutesBuilder', () => {

jest.spyOn(builder, 'generateExceptionProxyRender')
.mockReturnValue(exceptionProxyRenderTally)
const flushResponseSpy = jest.spyOn(builder, 'flushResponse')

const flushResponseSpy = jest.spyOn(renderer, 'flushResponse')

const handler = builder.generateRendererHandler({
renderer,
Expand All @@ -692,7 +696,7 @@ describe('RestfulApiRoutesBuilder', () => {

const expected = {
expressResponse: expressResponseMock,
response: responseTally,
renderResponse: responseTally,
}

expect(flushResponseSpy)
Expand Down