✅️ Implement family of RestfulApiResponseFlusher
#382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onseFlusher ⚒️ Declare `BaseRestfulApiResponseFlusher`
…onseFlusher ⚒️ Declare `JsonRestfulPpiResponseFlusher`
…onseFlusher ⚒️ Declare `HtmlRestfulApiResponseFlusher`
…nseFlusher ⚒️ Declare `CsvRestfulApiResponseFlusher`
There was a problem hiding this comment.
Pull Request Overview
This PR implements a family of RESTful API response flushers for JSON, HTML, and CSV formats to handle API responses uniformly. Key changes include the addition of concrete flusher classes in the library and comprehensive tests covering behavior and header/content handling for each format.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/tests/server/restfulapi/flushers/concretes/JsonRestfulApiResponseFlusher.js | Tests for JSON flusher behavior and implementation details. |
| tests/tests/server/restfulapi/flushers/concretes/HtmlRestfulApiResponseFlusher.js | Tests for HTML flusher behavior and output correctness. |
| tests/tests/server/restfulapi/flushers/concretes/CsvRestfulApiResponseFlusher.js | Tests for CSV flusher behavior and ensuring proper content delivery. |
| lib/server/restfulapi/flushers/concretes/JsonRestfulApiResponseFlusher.js | Implementation of the JSON response flusher using a JSON body generator. |
| lib/server/restfulapi/flushers/concretes/HtmlRestfulApiResponseFlusher.js | Implementation of the HTML response flusher sending HTML content. |
| lib/server/restfulapi/flushers/concretes/CsvRestfulApiResponseFlusher.js | Implementation of the CSV response flusher sending CSV content. |
| lib/server/restfulapi/flushers/BaseRestfulApiResponseFlusher.js | Base class defining common functionality such as header and status flushing. |
StewEucen
merged commit baac5df
into
retake/RESTful-API-flushing-structure
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
RestfulApiResponseFlusherstructure #365How