🧩 Tidy up types for Express
#364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dler() with ExpressType.NextFunction
…oxyRender() with ExpressType.Request
There was a problem hiding this comment.
Pull Request Overview
This pull request cleans up type annotations for Express by replacing inline import types with a unified ExpressType alias.
- Removed unused JSDoc typedef for ExpressRequest in test stub
- Updated Express type annotations in test files and production code to use ExpressType alias
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/stubs/StubExpressRequest.js | Removed the inline typedef for ExpressRequest |
| tests/tests/server/restfulapi/RestfulApiRoutesBuilder.js | Updated type annotations for NextFunction and Request to use ExpressType |
| lib/server/restfulapi/RestfulApiRoutesBuilder.js | Updated type annotation for expressResponse to use ExpressType |
Comments suppressed due to low confidence (2)
lib/server/restfulapi/RestfulApiRoutesBuilder.js:377
- Ensure that the ExpressType alias is properly imported or declared in the module so that this type reference resolves correctly.
* expressResponse: ExpressType.Response
tests/tests/server/restfulapi/RestfulApiRoutesBuilder.js:610
- Confirm that the ExpressType alias is available in this test module or import it as needed to avoid potential type resolution issues.
/** @type {ExpressType.NextFunction} */
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Express#363