Skip to content

💪 Remove unnecessary rules #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 27, 2024
Merged

💪 Remove unnecessary rules #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7182eca
Update all test cases
StewEucen May 27, 2024
7b74e22
Remove all rules
StewEucen May 27, 2024
2505b53
Add JSDoc plugin rules
StewEucen May 27, 2024
216e3c9
Adjust main exports
StewEucen May 27, 2024
4ab8718
Adjust eslint.config.js
StewEucen May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
'use strict'

const jsRules = require('@eslint/js')
const jestPlugin = require('eslint-plugin-jest')
const openreachtechPlugin = require('eslint-plugin-openreachtech')

const ruleHash = require('./index')
const jsdocPlugin = require('./index')

const jestFlatConfigRecommended = jestPlugin.configs['flat/recommended']

/**
* ESLint Config
Expand Down Expand Up @@ -36,8 +40,9 @@ module.exports = [

{
rules: {
...ruleHash.core.rules,
...ruleHash.disableCoreStylistic.rules,
...jsRules.configs
.all
.rules,

indent: [
'error',
Expand Down Expand Up @@ -1561,10 +1566,10 @@ module.exports = [
},
},
{
...ruleHash.jest,
...jestFlatConfigRecommended,

rules: {
...ruleHash.jest.rules,
...jestFlatConfigRecommended.rules,

'jest/consistent-test-it': [
'error',
Expand Down Expand Up @@ -1772,12 +1777,10 @@ module.exports = [
},
},
{
plugins: {
...ruleHash.jsdoc.plugins,
},
...jsdocPlugin,

rules: {
...ruleHash.jsdoc.rules,
...jsdocPlugin.rules,

'jsdoc/check-access': [
'error',
Expand Down
16 changes: 1 addition & 15 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,3 @@
'use strict'

const core = require('./rules/core.js')
const disableCoreStylistic = require('./rules/disable-core-stylistic.js')
const stylisticJs = require('./rules/plugins/stylistic/js.js')
const stylisticPlus = require('./rules/plugins/stylistic/plus.js')
const jestPlugin = require('./rules/plugins/jest.js')
const jsdocPlugin = require('./rules/plugins/jsdoc.js')

module.exports = {
core,
disableCoreStylistic,
stylisticJs,
stylisticPlus,
jest: jestPlugin,
jsdoc: jsdocPlugin,
}
module.exports = require('./rules/core')
16 changes: 1 addition & 15 deletions index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,4 @@
import { createRequire } from 'module'
const require = createRequire(import.meta.url)

export const core = require('./rules/core')
export const disableCoreStylistic = require('./rules/disable-core-stylistic')
export const stylisticJs = require('./rules/plugins/stylistic/js')
export const stylisticPlus = require('./rules/plugins/stylistic/plus')
export const jest = require('./rules/plugins/jest')
export const jsdoc = require('./rules/plugins/jsdoc')

export default {
core,
disableCoreStylistic,
stylisticJs,
stylisticPlus,
jest,
jsdoc,
}
export default require('./rules/core')
Loading
Loading