🛠 Create rule to `no-static-class`

[StewEucen]

Overview

• Add rule to no-static-class.

Tasks

• Survey

  • Consider to apply no-static-class rule by standard rules only.
    • If possible, declare it.
  • If not possible, create custom rule in eslint-plugin-openreachtech repository.

• Declare

  • Apply selector to rule.

[StewEucen]

• It works to catch static method without .create() and .createFulfilled().

MethodDefinition[static=true]:not(:has(Identifier[name=/^create(?:Fulfilled)?$/]))

[StewEucen]

• Found the selector.

ClassDeclaration:not(:has(MethodDefinition[static=false])):has(MethodDefinition[static=true]:not(:has(Identifier[name=/^(?:create|createFulfilled)$/])))

ClassDeclaration:not(
  :has(
    MethodDefinition[static=false]
  )
):has(
  MethodDefinition[static=true]:not(
    :has(
      Identifier[name=/^(?:create|createFulfilled)$/]
    )
  )
)

[StewEucen]

• 「DateNormalizer」みたいな static class をどうするか問題。

Solution

• renchan-tools だけ、此のルールを外せば好い。

[StewEucen]

• createFulfilled → createAsync