Skip to content

Comments

use dtype with fallback#324

Merged
kmuehlbauer merged 3 commits intoopenradar:mainfrom
katelbach:fix_odim_export_dtype
Feb 3, 2026
Merged

use dtype with fallback#324
kmuehlbauer merged 3 commits intoopenradar:mainfrom
katelbach:fix_odim_export_dtype

Conversation

@katelbach
Copy link
Contributor

@katelbach katelbach commented Feb 3, 2026

Minor fix as I noted that ODIM H5 exports fail because the fallback value for dtype is not used in an if query.

  • Tests added
  • Changes are documented in history.md

@kmuehlbauer kmuehlbauer enabled auto-merge (squash) February 3, 2026 10:07
Copy link
Collaborator

@kmuehlbauer kmuehlbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @katelbach! I think we can get this now. All in place!

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.59%. Comparing base (c94d306) to head (e18e829).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #324   +/-   ##
=======================================
  Coverage   93.59%   93.59%           
=======================================
  Files          27       27           
  Lines        5653     5653           
=======================================
  Hits         5291     5291           
  Misses        362      362           
Flag Coverage Δ
notebooktests 0.00% <0.00%> (ø)
unittests 93.59% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kmuehlbauer kmuehlbauer disabled auto-merge February 3, 2026 10:18
@kmuehlbauer kmuehlbauer merged commit e8ecb8d into openradar:main Feb 3, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants