Refactor: Consolidated pronom modules into pronom package and created a utils package #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t. Moved the pronom related modules to the pronom package as a basis for future refactoring.
There was a problem hiding this comment.
Copilot reviewed 8 out of 11 changed files in this pull request and generated no suggestions.
Files not reviewed (3)
- fido/pronom/prepare.py: Evaluated as low risk
- fido/fido.py: Evaluated as low risk
- fido/pronom/update_signatures.py: Evaluated as low risk
… to use defusedxml rather than xml.etree. Also modifications in pronom.prepare to avoid using some python builtin identifiers like input, id, zip.
the Codacy review. The main was to use defusedxml rather than xml.etree. Also made modifications in pronom.prepare to avoid using python builtin identifiers input, id, zip.
the Codacy review. The main was to use defusedxml rather than xml.etree. Also made modifications in pronom.prepare to avoid using python builtin identifiers input, id, zip.
…b.com/openpreserve/fido into dev/1.8/consolidate-pronom-components
|
Codacy static analysis seems to be out of tokens today, so does not complete. |
adamfarquhar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the pronom related modules to the pronom package as a basis for future refactoring. Created a utils package and added the char_handler and PerfTimer into it.