Creating setuphandler to allow in-game set up to be queried via API #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pwdel
changed the title
ajlacey
approved these changes
Aug 25, 2024
Comment on lines
+24
to
+26
| MockConfigLoader: func() (*setup.EconomicConfig, error) { | ||
| return setup.LoadEconomicsConfig() | ||
| }, |
There was a problem hiding this comment.
I like the way you did this! Can we add an error case as well, where the config fails to load?
There was a problem hiding this comment.
Added and tagged a ticket within refactoring for this.
https://github.com/orgs/openpredictionmarkets/projects/6/views/1?pane=issue&itemId=76289411
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ticket: https://github.com/orgs/openpredictionmarkets/projects/4/views/1?pane=issue&itemId=76257552
To test, load branch and visit:
http://localhost/api/v0/setup