Skip to content

Conversation

@thomedw
Copy link

@thomedw thomedw commented Mar 19, 2023

This PR bumps opencv version to 4.7.0.

I have run the checks, including the macos arm64, and it seems OK to me.
Screenshot 2023-03-20 at 11 39 21

@thomedw thomedw force-pushed the bump/opencv-4.7.0 branch from 97e3f48 to 9285d0f Compare March 20, 2023 01:51
@thomedw thomedw marked this pull request as ready for review March 20, 2023 04:41
@vonnieda
Copy link
Member

Excellent, thank you @thomedw! Very much appreciate your effort on this!

I'll run a couple quick tests and get this merged!

@thomedw
Copy link
Author

thomedw commented Mar 23, 2023

Hi @vonnieda,

Thank you for taking the time to review and check this PR. I appreciate your efforts in testing and merging my code.

I was wondering if there's an estimated timeline for when my pull request might be merged? I'm excited to see my contributions being added to the project.

If there's anything else you need from me, please let me know. I'm available to make any further changes or help in any way I can.

Thanks again for your time and efforts.

Best regards,
Thomas

@vonnieda
Copy link
Member

Looks good, thanks again @thomedw! I had a concern about the changed URL for the windows download, but I verified the files look good.

@vonnieda vonnieda merged commit 13ea0a2 into openpnp:develop Mar 27, 2023
@vonnieda vonnieda mentioned this pull request Mar 27, 2023
@thomedw
Copy link
Author

thomedw commented Mar 28, 2023

I'm glad to hear that the files look good. Again, thank you very much for taking the time to review and merge.

@thomedw thomedw deleted the bump/opencv-4.7.0 branch April 1, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants