Skip to content

Conversation

dorien-er
Copy link
Contributor

@dorien-er dorien-er commented Apr 25, 2024

Changelog

  • Workflow for scGPT integration followed by Leiden clustering
  • Allow for passing fine-tuned models in embedding component

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

dorien-er and others added 30 commits March 6, 2024 11:16
* add script to download scgpt test resources

* Update resources_test_scripts/scgpt.sh

Co-authored-by: Dries Schaumont <5946712+DriesSchaumont@users.noreply.github.com>

* add drive folders containing data and model

* chmod +x

---------

Co-authored-by: Dries Schaumont <5946712+DriesSchaumont@users.noreply.github.com>
Copy link
Member

@DriesSchaumont DriesSchaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot seem to build the workflow:

$ viash ns build -q scgpt_leiden
Reading file 'src/workflows/integration/scgpt_leiden/config.vsh.yaml' failed
Not all configs built successfully
  131 configs were disabled
  1/1 configs encountered parse errors

dorien-er and others added 3 commits August 14, 2024 16:13
Address requested PR changes

Co-authored-by: Dries Schaumont <5946712+DriesSchaumont@users.noreply.github.com>
@dorien-er
Copy link
Contributor Author

PR requested changes are addressed :-)

Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor remark in the code.

Could you post the output of the integration test? 🙇

@dorien-er
Copy link
Contributor Author

dorien-er commented Sep 6, 2024

Minor remark in the code.

Could you post the output of the integration test? 🙇

Exporting scgpt_leiden (workflows/integration) =nextflow=> .../openpipeline/target/nextflow/workflows/integration/scgpt_leiden
Not all configs built successfully
  139 configs were disabled
  1/1 configs built successfully
Nextflow 24.04.4 is available - Please consider updating your version to it
N E X T F L O W  ~  version 21.10.6
Launching src/workflows/integration/scgpt_leiden/test.nf` [serene_chandrasekhar] - revision: cf3a3008c8
executor >  local (18)
[1c/78a5d3] process > test_wf:scgpt_leiden:run_wf:highly_variable_features_scanpy:processWf:highly_variable_features_scanpy_process (no_leiden_resolutions_test) [100%] 2 of 2 ✔
[ef/9cc287] process > test_wf:scgpt_leiden:run_wf:do_filter:processWf:do_filter_process (no_leiden_resolutions_test)                                             [100%] 2 of 2 ✔
[20/8ebf3f] process > test_wf:scgpt_leiden:run_wf:cross_check_genes:processWf:cross_check_genes_process (no_leiden_resolutions_test)                             [100%] 2 of 2 ✔
[51/fd44cc] process > test_wf:scgpt_leiden:run_wf:binning:processWf:binning_process (no_leiden_resolutions_test)                                                 [100%] 2 of 2 ✔
[39/36f2c6] process > test_wf:scgpt_leiden:run_wf:pad_tokenize:processWf:pad_tokenize_process (no_leiden_resolutions_test)                                       [100%] 2 of 2 ✔
[d4/37a03e] process > test_wf:scgpt_leiden:run_wf:embedding:processWf:embedding_process (no_leiden_resolutions_test)                                             [100%] 2 of 2 ✔
[3b/ff6912] process > test_wf:scgpt_leiden:run_wf:find_neighbors:processWf:find_neighbors_process (no_leiden_resolutions_test)                                   [100%] 2 of 2 ✔
[45/1a083f] process > test_wf:scgpt_leiden:run_wf:leiden:processWf:leiden_process (simple_execution_test)                                                        [100%] 1 of 1 ✔
[27/16ab50] process > test_wf:scgpt_leiden:run_wf:move_obsm_to_obs:processWf:move_obsm_to_obs_process (simple_execution_test)                                    [100%] 1 of 1 ✔
[07/48a516] process > test_wf:scgpt_leiden:run_wf:umap:processWf:umap_process (no_leiden_resolutions_test)                                                       [100%] 2 of 2 ✔
Output: [simple_execution_test, [output:.../openpipeline/work/15/827e8f2d834d905980ffaa5f0f3cbe/simple_execution_test.umap.output.h5mu]]
Output: [no_leiden_resolutions_test, [output:.../openpipeline/work/07/48a516c120091818b9f0bbba5b285b/no_leiden_resolutions_test.umap.output.h5mu]]
Completed at: 06-Sep-2024 10:23:35
Duration    : 5m 16s
CPU hours   : 0.2
Succeeded   : 18


Nextflow 24.04.4 is available - Please consider updating your version to it
N E X T F L O W  ~  version 21.10.6
Launching `src/workflows/integration/scgpt_leiden/test.nf` [modest_fermi] - revision: cf3a3008c8
executor >  local (10)
[7c/648a99] process > test_wf2:scgpt_leiden:run_wf:highly_variable_features_scanpy:processWf:highly_variable_features_scanpy_process (test_output_arg) [100%] 1 of 1 ✔
[46/b703df] process > test_wf2:scgpt_leiden:run_wf:do_filter:processWf:do_filter_process (test_output_arg)                                             [100%] 1 of 1 ✔
[23/d42f40] process > test_wf2:scgpt_leiden:run_wf:cross_check_genes:processWf:cross_check_genes_process (test_output_arg)                             [100%] 1 of 1 ✔
[d6/daf018] process > test_wf2:scgpt_leiden:run_wf:binning:processWf:binning_process (test_output_arg)                                                 [100%] 1 of 1 ✔
[d1/5cdffa] process > test_wf2:scgpt_leiden:run_wf:pad_tokenize:processWf:pad_tokenize_process (test_output_arg)                                       [100%] 1 of 1 ✔
[fd/1cfe12] process > test_wf2:scgpt_leiden:run_wf:embedding:processWf:embedding_process (test_output_arg)                                             [100%] 1 of 1 ✔
[ab/c8d4dc] process > test_wf2:scgpt_leiden:run_wf:find_neighbors:processWf:find_neighbors_process (test_output_arg)                                   [100%] 1 of 1 ✔
[6f/8e7535] process > test_wf2:scgpt_leiden:run_wf:leiden:processWf:leiden_process (test_output_arg)                                                   [100%] 1 of 1 ✔
[86/bbaec4] process > test_wf2:scgpt_leiden:run_wf:move_obsm_to_obs:processWf:move_obsm_to_obs_process (test_output_arg)                               [100%] 1 of 1 ✔
[09/d0b70c] process > test_wf2:scgpt_leiden:run_wf:umap:processWf:umap_process (test_output_arg)                                                       [100%] 1 of 1 ✔
Output: [test_output_arg, [output:.../openpipeline/work/09/d0b70c48b14bfd4bcfd6b023489b95/test.h5mu]]

Completed at: 06-Sep-2024 10:26:43
Duration    : 3m 1s
CPU hours   : 0.1
Succeeded   : 10

@dorien-er dorien-er requested a review from rcannood September 6, 2024 09:00
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dorien-er dorien-er merged commit ae0e1d6 into main Sep 6, 2024
5 checks passed
@dorien-er dorien-er deleted the scgpt-integration branch September 6, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants