-
Notifications
You must be signed in to change notification settings - Fork 14
scGPT integration workflow #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
scGPT integration preproc module
* add script to download scgpt test resources * Update resources_test_scripts/scgpt.sh Co-authored-by: Dries Schaumont <5946712+DriesSchaumont@users.noreply.github.com> * add drive folders containing data and model * chmod +x --------- Co-authored-by: Dries Schaumont <5946712+DriesSchaumont@users.noreply.github.com>
merge scgpt-dev into scgpt
Co-authored-by: Dries Schaumont <5946712+DriesSchaumont@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot seem to build the workflow:
$ viash ns build -q scgpt_leiden
Reading file 'src/workflows/integration/scgpt_leiden/config.vsh.yaml' failed
Not all configs built successfully
131 configs were disabled
1/1 configs encountered parse errors
Address requested PR changes Co-authored-by: Dries Schaumont <5946712+DriesSchaumont@users.noreply.github.com>
PR requested changes are addressed :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor remark in the code.
Could you post the output of the integration test? 🙇
Co-authored-by: Robrecht Cannoodt <rcannood@gmail.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Changelog
Issue ticket number and link
Checklist before requesting a review
I have performed a self-review of my code
Conforms to the Contributor's guide
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI tests succeed!