-
Notifications
You must be signed in to change notification settings - Fork 31
Z Meeting notes, 2022 03 14
Tim Treis edited this page Mar 10, 2022
·
10 revisions
- Riskmetric badge is not rendered correctly (#337)
- Use CRAN as
main
(#331, #333) - Clean up
visR
for 0.3 (#334, #332, #329, #325, #323, #324, #300, #299) - README GH Action now only runs on "important" branches (#340, #342)
- Sprint planning
1. Riskmetric badge is not rendered correctly (#337)
- @timtreis:
riskmetric
is not working properly in its current (default) release, therefore we're now explicitly loading an older still working version when generating the README. Issue is "fixed" but I'll leave it open since we should default to the most modern branch and I want more people to be aware of this technical debt in case I forget.
-
@timtreis: The docs (https://openpharma.github.io/visR/) are rendered based on
main
. By not actually havingmain
as our dev branch, it is basically never updated. Do we want that page to reflect CRAN or our current dev version?- from @ddsjoberg: if you make this update (which I support), I recommend updating before the sprint begins so that PRs made during the sprint don't have to change the target branch.
- @ddsjoberg did a thorough review of our package and identified quite a few aspects we've been neglecting until now. Many of those are organisational, we could tackle them for the next release as a general "modernisation/cleanup" effort. We should organize the issues inside milestones.
- #324 is merged -> We're now actually checking the versions we say we are compatible to (thanks @ddsjoberg!)
- Previously, the GH Action that generated our README was run on all PRs and then committed them to the PR. Now it is only done after merging into
main
anddevelop
.