Skip to content

Comments

Prevent Rcpp from masking valid uses of Rf_error#556

Merged
danielinteractive merged 1 commit intoopenpharma:mainfrom
Enchufa2:main
Jan 7, 2026
Merged

Prevent Rcpp from masking valid uses of Rf_error#556
danielinteractive merged 1 commit intoopenpharma:mainfrom
Enchufa2:main

Conversation

@Enchufa2
Copy link
Contributor

This PR sets the -DRCPP_NO_MASK_RF_ERROR flag to prevent Rcpp from masking valid calls to Rf_error.

At Rcpp, we plan to warn about this (see this issue for further discussion), and at some point stop the compilation with an error message, forcing the maintainers to take action. For valid uses of Rf_error, like in this package, we will provide this opt-out switch. Therefore, we kindly ask you to apply this patch and send an update to CRAN at your earliest convenience.

@danielinteractive
Copy link
Collaborator

Thanks a lot @Enchufa2 for your work on Rcpp and in particular this PR! Much appreciated.

I will then submit a new mmrm package version to CRAN after the CRAN holidays.

@danielinteractive danielinteractive merged commit 78a0e15 into openpharma:main Jan 7, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants