Skip to content

Migrate to TS #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 6, 2023
Merged

Migrate to TS #25

merged 8 commits into from
Jun 6, 2023

Conversation

johnnyasantoss
Copy link
Member

  • Upgrade dependencies
  • Migrate to Typescript
  • Use pnpm
  • Add response and requests types

@johnnyasantoss johnnyasantoss self-assigned this Mar 21, 2023
joaodealmeida
joaodealmeida reviewed Apr 5, 2023
View reviewed changes
joaodealmeida
joaodealmeida reviewed Apr 5, 2023
View reviewed changes
joaodealmeida
joaodealmeida reviewed Apr 5, 2023
View reviewed changes
joaodealmeida
joaodealmeida reviewed Apr 5, 2023
View reviewed changes
joaodealmeida
joaodealmeida reviewed Apr 13, 2023
View reviewed changes
joaodealmeida
joaodealmeida suggested changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@joaodealmeida joaodealmeida left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments

joaodealmeida

This comment was marked as outdated.

Sign in to view

@joaodealmeida joaodealmeida self-requested a review April 13, 2023 21:46
joaodealmeida
joaodealmeida suggested changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@joaodealmeida joaodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are not running

> opennode@1.5.0 test
> mocha


Error: Cannot find module '../src/lib'

@johnnyasantoss johnnyasantoss merged commit d88022f into master Jun 6, 2023
@johnnyasantoss johnnyasantoss deleted the ts branch June 6, 2023 19:47
This was referenced Jun 6, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaodealmeida joaodealmeida joaodealmeida approved these changes

@ruigomeseu ruigomeseu Awaiting requested review from ruigomeseu

Assignees

@johnnyasantoss johnnyasantoss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnnyasantoss @joaodealmeida