Skip to content

fix: de-duplicate blob operation spans #3279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 4, 2025
Merged

fix: de-duplicate blob operation spans #3279

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aa1b3b6
fix: de-duplicate blob operation spans
mrstork Nov 26, 2025
2a01efd
fix: clean up redundant attributes
mrstork Nov 26, 2025
aa700a3
Merge branch 'main' into passed-span-option
mrstork Dec 3, 2025
9ca0a71
fix: remove duplicate blob key attribute in setJSON requests
mrstork Dec 3, 2025
fff0407
Merge branch 'main' into passed-span-option
mrstork Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions src/run/storage/storage.cts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,12 @@ export const getMemoizedKeyValueStoreBackedByRegionalBlobStore = (
? memoizedValue
: {}

span?.setAttributes({ key, blobKey, previousEtag })
span?.setAttributes({ key })

const result = await store.getWithMetadata(blobKey, {
type: 'json',
etag: previousEtag,
span,
})

const shouldReuseMemoizedBlob = result?.etag && previousEtag === result?.etag
Expand All @@ -61,12 +62,6 @@ export const getMemoizedKeyValueStoreBackedByRegionalBlobStore = (
inMemoryCache.set(key, blob)
}

span?.setAttributes({
etag: result?.etag,
reusingPreviouslyFetchedBlob: shouldReuseMemoizedBlob,
status: blob ? (shouldReuseMemoizedBlob ? 'Hit, no change' : 'Hit') : 'Miss',
})

return blob
})
inMemoryCache.set(key, getPromise)
Expand All @@ -79,8 +74,8 @@ export const getMemoizedKeyValueStoreBackedByRegionalBlobStore = (

const blobKey = await encodeBlobKey(key)
return withActiveSpan(tracer, otelSpanTitle, async (span) => {
span?.setAttributes({ key, blobKey })
const writeResult = await store.setJSON(blobKey, value)
span?.setAttributes({ key })
const writeResult = await store.setJSON(blobKey, value, { span })
if (writeResult?.etag) {
inMemoryCache.set(key, {
data: value,
Expand Down
Loading