Skip to content

fix(tagCache): gracefully handle empty tag list #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025
Merged

fix(tagCache): gracefully handle empty tag list #581

merged 2 commits into from
Apr 14, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Apr 14, 2025

fixes #576

Copy link

changeset-bot bot commented Apr 14, 2025

🦋 Changeset detected

Latest commit: cc8485d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Apr 14, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@581

commit: cc8485d

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Copy link
Collaborator

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do it here aswell

@vicb
Copy link
Contributor Author

vicb commented Apr 14, 2025

We should do it here aswell

Woudn't that code path work with an empty tag list?

@vicb vicb requested a review from conico974 April 14, 2025 18:20
Copy link
Collaborator

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it should work just fine. Thanks

@vicb
Copy link
Contributor Author

vicb commented Apr 14, 2025

You're right, it should work just fine. Thanks

Note that I would have added it if the root cause was not fixed upstream.

Thanks for the review!

@vicb vicb merged commit c7c5d3d into main Apr 14, 2025
7 checks passed
@vicb vicb deleted the vb-branch-7 branch April 14, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Worker tries to revalidate empty tags resulting in: D1_ERROR: No SQL statements detected.
2 participants