-
Notifications
You must be signed in to change notification settings - Fork 45
fix(tagCache): gracefully handle empty tag list #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: cc8485d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should do it here aswell
opennextjs-cloudflare/packages/cloudflare/src/api/overrides/tag-cache/do-sharded-tag-cache.ts
Line 256 in 68d6bb4
if (isDisabled) return; |
Woudn't that code path work with an empty tag list? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, it should work just fine. Thanks
Note that I would have added it if the root cause was not fixed upstream. Thanks for the review! |
fixes #576