Skip to content

fix: No body for 101, 204, 205, or 304 status code #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Dec 20, 2024

Fix a KI when browser cache was enabled by pulling the fix from opennextjs/opennextjs-aws#683

Copy link

changeset-bot bot commented Dec 20, 2024

⚠️ No Changeset found

Latest commit: 0d341ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Dec 20, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@195

commit: 0d341ee

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is a KI?

I feel uncomfortable about landing "fixes" with no tests.
How hard would it be to add tests that prove this bump to the aws dependency fixes the problem?

@vicb
Copy link
Contributor Author

vicb commented Dec 20, 2024

KI = known issue (See the README update).

I tested locally with the blog example, reloading the page would generated the error as it adds a body to a 304. This might be possible to e2e but I'm not sure how e2e behaves regarding to cache.

I'm confident that the issue is fixed.

Copy link
Collaborator

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vicb vicb merged commit 0859c01 into experimental Dec 20, 2024
6 checks passed
@vicb vicb deleted the fix/browser-cache branch December 20, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants