fix: new Request(request, init) crashing in route handlers on workerd #1145
Open
ama2369 wants to merge 1 commit intoopennextjs:mainfrom
Open
fix: new Request(request, init) crashing in route handlers on workerd #1145ama2369 wants to merge 1 commit intoopennextjs:mainfrom
ama2369 wants to merge 1 commit intoopennextjs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 5f2ef56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
e68f009 to
9ea1036
Compare
9ea1036 to
5f2ef56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1144. Likely also fixes #1037.
new Request(request, { headers })in route handlers crashes withTypeError: Invalid URL: [object Request]because therequestobject isn't recognized as a nativeRequestby workerd's constructor.The fix captures
OriginalRequestbefore overwritingglobalThis.Request, adds aninstanceofguard, and extracts.urlwith merged properties for non-native objects.What changed
packages/cloudflare/src/cli/templates/init.tsOriginalRequestbefore replacement for reliableinstanceofchecksOriginalRequestinstances pass through tosuper()directly.url, mergemethod/headers/bodyinto init, setduplex: "half"when body is presentTest plan
new Request(request, { headers })works in route handlers (the bug)stream.Readablebody conversion still works (existing behavior)