Skip to content

Comments

Add an rclone based option to populate the R2 cache#1116

Open
grabmateusz wants to merge 10 commits intoopennextjs:mainfrom
grabmateusz:task/recover-rclone-to-bypass-account-rate-limits
Open

Add an rclone based option to populate the R2 cache#1116
grabmateusz wants to merge 10 commits intoopennextjs:mainfrom
grabmateusz:task/recover-rclone-to-bypass-account-rate-limits

Conversation

@grabmateusz
Copy link

@grabmateusz grabmateusz commented Feb 6, 2026

This PR is recovering concept of R2 cache upload using rclone to address issues related to Account Level Rate Limits which appear for projects with bigger ISR cache (details in #1110)

@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2026

🦋 Changeset detected

Latest commit: def3d3b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like a great start, thanks for looking at it.

Could you please:

  • address my inline comments
  • make it very clear in the PR description what code from for where (file + sha)

Thanks!

@grabmateusz
Copy link
Author

@vicb I have resolved all remarks, please do second round of review, thank you for your feedback so far :)

@vicb vicb changed the title Recover #925 PR concept for projects with huge R2 incremental cache Add an rclone based option to populate the R2 cache Feb 6, 2026
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's an AI writing this code?

Please double check the quality before asking me to review again.

Thanks!

grabmateusz and others added 2 commits February 6, 2026 14:39
Co-authored-by: Victor Berchet <victor@suumit.com>
@grabmateusz grabmateusz force-pushed the task/recover-rclone-to-bypass-account-rate-limits branch from 2fbb2c2 to 4e82fe2 Compare February 6, 2026 13:40
@grabmateusz
Copy link
Author

grabmateusz commented Feb 6, 2026

@vicb all the remarks handled. Thank you for your review and looking forward for another round :)

@vicb
Copy link
Contributor

vicb commented Feb 6, 2026

Could you

Please double check the quality before asking me to review again.

And also create the associated doc PR at https://github.com/opennextjs/docs (you can start from the initial or the revert PR)

I'll review again on Monday,

Thanks!

@grabmateusz
Copy link
Author

@vicb I have double checked the quality, it meets my quality criteria on code level, I hope it will meet your quality criteria as well, apologies if any of the previous submissions did not meet your code quality.
I have double checked that I am able to consume this version of OpenNext CF Adapter locally on my project.
I've created PR to docs repository opennextjs/docs#207

Have a great weekend, I look forward for your review on Monday.

@vicb vicb force-pushed the task/recover-rclone-to-bypass-account-rate-limits branch from 1a6fd02 to def3d3b Compare February 8, 2026 06:57
@vicb
Copy link
Contributor

vicb commented Feb 8, 2026

@grabmateusz I pushed some updates to the PR, let me know what you think and please test the pre-release.

Thanks!

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 8, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@opennextjs/cloudflare@1116

commit: def3d3b

@grabmateusz
Copy link
Author

Hi @vicb, I've checked your changed, look good to me, I've consumed pre-release package on my project and works like expected, CI/CD including, I look forward for PR to be accepted and merged, then I will update docs PR with proper version.
Thanks for all your inputs.

@vicb
Copy link
Contributor

vicb commented Feb 9, 2026

Hi @vicb, I've checked your changed, look good to me, I've consumed pre-release package on my project and works like expected, CI/CD including, I look forward for PR to be accepted and merged, then I will update docs PR with proper version. Thanks for all your inputs.

Thanks for the feedback and taking the time to test.

I see that @isaacrowntree has updated #1099 which is the way I think we should head. I'll take a look soon and decide if this PR should be merged or if #1099 is ready instead.

@grabmateusz
Copy link
Author

@vicb I've tried #1099 and it's newest version ends for me with:
Screenshot 2026-02-09 at 08 39 17
just FYI

@vicb
Copy link
Contributor

vicb commented Feb 9, 2026

@vicb I've tried #1099 and it's newest version ends for me with: Screenshot 2026-02-09 at 08 39 17 just FYI

Thanks for the feedback, that's helpful.
I'll ping you later today when there is something ready to try.
My current plan is to get the PR to a mergeable state first and then follow up with a few improvements

@vicb
Copy link
Contributor

vicb commented Feb 9, 2026

I have a proto in #1121 (based on #1099).

I need to polish the error handling but it should be useable if your remote R2 exists.
Feel free to try and report if that works for you and to review the PR.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants