Add an rclone based option to populate the R2 cache#1116
Add an rclone based option to populate the R2 cache#1116grabmateusz wants to merge 10 commits intoopennextjs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: def3d3b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
vicb
left a comment
There was a problem hiding this comment.
Look like a great start, thanks for looking at it.
Could you please:
- address my inline comments
- make it very clear in the PR description what code from for where (file + sha)
Thanks!
|
@vicb I have resolved all remarks, please do second round of review, thank you for your feedback so far :) |
vicb
left a comment
There was a problem hiding this comment.
I guess it's an AI writing this code?
Please double check the quality before asking me to review again.
Thanks!
Co-authored-by: Victor Berchet <victor@suumit.com>
2fbb2c2 to
4e82fe2
Compare
|
@vicb all the remarks handled. Thank you for your review and looking forward for another round :) |
|
Could you
And also create the associated doc PR at https://github.com/opennextjs/docs (you can start from the initial or the revert PR) I'll review again on Monday, Thanks! |
|
@vicb I have double checked the quality, it meets my quality criteria on code level, I hope it will meet your quality criteria as well, apologies if any of the previous submissions did not meet your code quality. Have a great weekend, I look forward for your review on Monday. |
1a6fd02 to
def3d3b
Compare
|
@grabmateusz I pushed some updates to the PR, let me know what you think and please test the pre-release. Thanks! |
commit: |
|
Hi @vicb, I've checked your changed, look good to me, I've consumed pre-release package on my project and works like expected, CI/CD including, I look forward for PR to be accepted and merged, then I will update docs PR with proper version. |
Thanks for the feedback and taking the time to test. I see that @isaacrowntree has updated #1099 which is the way I think we should head. I'll take a look soon and decide if this PR should be merged or if #1099 is ready instead. |


This PR is recovering concept of R2 cache upload using rclone to address issues related to Account Level Rate Limits which appear for projects with bigger ISR cache (details in #1110)