-
Notifications
You must be signed in to change notification settings - Fork 92
Apply quality of life improvements to the opennextjs-cloudflare CLI
#1097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: f571523 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
9c7b0f2 to
42eba8f
Compare
Co-authored-by: James Anderson <james@eli.cx>
vicb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Dario 🙏
LGTM with one suggestion
|
oof... I guess I need to also instruct yargs to ignore the flags we forward to wrangler 😓 |
I guess that's a result of where .strictCommands() is used perhaps? |
maybe...? but without it passing wrong stuff to the opennext CLI doesn't trigger the error message 😓 |
Co-authored-by: Victor Berchet <victor@suumit.com>
|
Just pushed a change that should get the args working properly. There's a couple things at play now:
You can see the args ending up in the expected properties in the below screenshot:
|
|
|
|
Thanks for the fix @james-elicx 🙂 With your fix I think that things are a bit un-ideal since any flag passed to a command won't trigger any error/warning, however I don't think we can reasonably do much better given how the CLI accepts arguments Looks good to me 🙂👍 |


This PR improves the
opennextjs-cloudflareCLI by:opennextjs-cloudflare foo) display a clear and helpful error message-h|--helpflag to display the CLI's help message-v|--versionflag to display the package's version