Skip to content

fix(converters): refactor the constructing of URL in node converter #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2025

Conversation

sommeeeer
Copy link
Contributor

@sommeeeer sommeeeer commented May 18, 2025

We should create the URL like this instead.

Copy link

changeset-bot bot commented May 18, 2025

🦋 Changeset detected

Latest commit: 6daabe5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented May 18, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@867

commit: 6daabe5

@sommeeeer sommeeeer changed the title fix(converters): we remove leading forward slashes from url fix(converters): remove leading forward slashes from url May 18, 2025
@sommeeeer sommeeeer requested a review from conico974 May 18, 2025 20:43
@sommeeeer sommeeeer changed the title fix(converters): remove leading forward slashes from url fix(converters): refactor the constructing of URL in node converter May 18, 2025
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@conico974 conico974 merged commit 69a26e7 into opennextjs:main May 18, 2025
3 checks passed
@github-actions github-actions bot mentioned this pull request May 18, 2025
@sommeeeer sommeeeer deleted the fix-node-url branch May 19, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants