Skip to content

fix(tagCache): do not call writeTags with an empty list #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Apr 14, 2025

See opennextjs/opennextjs-cloudflare#576

Called from node_modules/next/dist/compiled/next-server/app-route.runtime.dev.js

_workStore_incrementalCache.revalidateTag(workStore.revalidatedTags||[])

Copy link

changeset-bot bot commented Apr 14, 2025

🦋 Changeset detected

Latest commit: a38e76e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 26.55% 2465 / 9282
🔵 Statements 26.55% 2465 / 9282
🔵 Functions 52.86% 129 / 244
🔵 Branches 73.4% 599 / 816
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/adapters/cache.ts 87.26% 83.63% 100% 87.26% 20-21, 80-82, 85-94, 151-162, 184-185, 362-370, 404-405, 438-447
Generated in workflow #1148 for commit a38e76e by the Vitest Coverage Report Action

Copy link

pkg-pr-new bot commented Apr 14, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@828

commit: a38e76e

@vicb vicb requested a review from conico974 April 14, 2025 17:37
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@vicb
Copy link
Contributor Author

vicb commented Apr 14, 2025

Thanks for the review!

@vicb vicb merged commit 195b67d into main Apr 14, 2025
3 checks passed
@vicb vicb deleted the vb-branch-7 branch April 14, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants