-
Notifications
You must be signed in to change notification settings - Fork 157
Fix i18n for domain #759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix i18n for domain #759
Conversation
🦋 Changeset detectedLatest commit: 9d6392a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
@nicholas-c Could you test with this patch pls ? pnpm add https://pkg.pr.new/@opennextjs/aws@759 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates!
(Thanks for adding tests for constructNextUrl
)
Co-authored-by: Victor Berchet <victor@suumit.com>
Thanks for the patch @conico974 Doesn't seem to be working still on the previews I put together on the issue I'm afraid 😰 I believe I've applied the patch properly, seems to be building with the new detectDomainLocales correctly. https://next-15-en.nich-carter-qza3ng.gymshark-sandbox.tools/ I've enabled OPEN_NEXT_DEBUG so can provide some of those logs if needed; My logs in the middleware still return this though;
|
Should fix #758
It also handles locale redirect directly in the routing layer instead of letting next handle it.