feat: invoke a remove method on the queue after cache set #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3d8e546 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
conico974
reviewed
Feb 10, 2025
There was a problem hiding this comment.
I'm not sure how useful this will be once deployed honestly. Revalidation involves a HEAD request, how likely is it that the same isolate will send and receive the HEAD request.
And just awaiting the fetch call and removing there is probably as effective (and at least you're certain that you are running on the same isolate)
|
Fair point. Makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this is that if we have an in-memory queue that wants to de-dupe on a per-isolate basis, we could invoke a method after the incremental cache set operation to remove the path from the list of active revalidations. Incremental cache set operation use the path as the key, so this should be a decent strategy for per-isolate queues.
includes #731 because i dont have permission to merge prs