Skip to content

remove any deps to @open-next/utils #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/tests-e2e/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
"dependencies": {},
"devDependencies": {
"@playwright/test": "1.37.0",
"@open-next/utils": "workspace:*",
"start-server-and-test": "2.0.0",
"ts-node": "10.9.1"
},
Expand Down
3 changes: 2 additions & 1 deletion packages/tests-e2e/tests/appPagesRouter/isr.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { wait } from "@open-next/utils";
import { expect, test } from "@playwright/test";

import { wait } from "../utils";

test("Incremental Static Regeneration", async ({ page }) => {
test.setTimeout(60000);
await page.goto("/");
Expand Down
3 changes: 2 additions & 1 deletion packages/tests-e2e/tests/appPagesRouter/pages_isr.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { wait } from "@open-next/utils";
import { expect, test } from "@playwright/test";

import { wait } from "../utils";

test("Incremental Static Regeneration", async ({ page }) => {
test.setTimeout(60000);
await page.goto("/");
Expand Down
3 changes: 2 additions & 1 deletion packages/tests-e2e/tests/appPagesRouter/pages_ssr.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { wait } from "@open-next/utils";
import { expect, test } from "@playwright/test";

import { wait } from "../utils";

test("Server Side Render", async ({ page }) => {
await page.goto("/");
await page.locator('[href="/pages_ssr"]').click();
Expand Down
3 changes: 2 additions & 1 deletion packages/tests-e2e/tests/appPagesRouter/ssr.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { wait } from "@open-next/utils";
import { expect, test } from "@playwright/test";

import { wait } from "../utils";

test("Server Side Render", async ({ page }) => {
await page.goto("/");
await page.locator('[href="/ssr"]').click();
Expand Down
3 changes: 2 additions & 1 deletion packages/tests-e2e/tests/appRouter/isr.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { wait } from "@open-next/utils";
import { expect, test } from "@playwright/test";

import { wait } from "../utils";

test("Incremental Static Regeneration", async ({ page }) => {
test.setTimeout(45000);
await page.goto("/");
Expand Down
3 changes: 2 additions & 1 deletion packages/tests-e2e/tests/appRouter/sse.test.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
// NOTE: loading.tsx is currently broken on open - next
// This works locally but not on deployed apps

import { wait } from "@open-next/utils";
import { expect, test } from "@playwright/test";

import { wait } from "../utils";

// NOTE: We don't await page load b/c we want to see the Loading page
test("Server Sent Events", async ({ page }) => {
await page.goto("/");
Expand Down
3 changes: 2 additions & 1 deletion packages/tests-e2e/tests/appRouter/ssr.test.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
// NOTE: loading.tsx is currently broken on open - next
// This works locally but not on deployed apps

import { wait } from "@open-next/utils";
import { expect, test } from "@playwright/test";

import { wait } from "../utils";

// NOTE: We don't await page load b/c we want to see the Loading page
test("Server Side Render and loading.tsx", async ({ page }) => {
test.setTimeout(600000);
Expand Down
3 changes: 2 additions & 1 deletion packages/tests-e2e/tests/pagesRouter/isr.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { wait } from "@open-next/utils";
import { expect, test } from "@playwright/test";

import { wait } from "../utils";

test("Incremental Static Regeneration", async ({ page }) => {
test.setTimeout(45000);
await page.goto("/");
Expand Down
3 changes: 2 additions & 1 deletion packages/tests-e2e/tests/pagesRouter/ssr.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { wait } from "@open-next/utils";
import { expect, test } from "@playwright/test";

import { wait } from "../utils";

test("Server Side Render", async ({ page }) => {
await page.goto("/");
await page.locator('[href="/ssr/"]').click();
Expand Down
3 changes: 3 additions & 0 deletions packages/tests-e2e/tests/utils.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export function wait(ms: number) {
return new Promise((resolve) => setTimeout(resolve, ms));
}
1 change: 0 additions & 1 deletion packages/tests-unit/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
"test": "vitest run --coverage"
},
"dependencies": {
"@open-next/utils": "workspace:*",
"@opennextjs/aws": "workspace:*"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/tests-unit/tests/binary.test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { isBinaryContentType } from "@open-next/utils";
import { isBinaryContentType } from "@opennextjs/aws/adapters/binary.js";

describe("isBinaryContentType", () => {
const tests = [
Expand Down
6 changes: 0 additions & 6 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading