fixes for PHP 7.2 #140
Merged
fixes for PHP 7.2 #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix as described by daviddpd in github ona repo issue opennetadmin#129: opennetadmin#129 PHP 7.x will no longer convert a variable initialized as null string to an array.
As of PHP 7.2 , a warning is issued that you cannot set session module
ini settings after the session is active.
PHP Warning: ini_set(): A session is active. You cannot change
the session module's ini settings at this time in
/opt/ona/www/config/config.inc.php on line 232
Apparently it has never worked to set gc.max_lifetime after session start
but no warning was issued so it was a silent failure.
https://bugs.php.net/bug.php?id=75650
As of PHP 7.1, $_SESSION is no longer intialized if the custom session read handler returns false or null. With $_SEESION not initialized, the the custom session write handler is not getting called (just close()). The way the ONA customer session handlers are written, this new PHP behavior results new sessions never being written to the database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes three PHP7.2 fixes:
PHP7.2 and $_SESSION not getting saved as discussed in #130.
The fix posted for #129
A previously unknown but long time issue exposed by PHP7.2 now issuing a warning stating session was already started when trying to set gc.max_lifetime.