Added custom_attribute_type_display dcm module #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $options = parse_options($options); | ||
|
|
||
| // Return the usage summary if we need to | ||
| if ($options['help'] or (!$options['id'] and !$options['name'])) { |
There was a problem hiding this comment.
I think the and here should be an or
| Synopsis: custom_attribute_type_display | ||
|
|
||
| Where: | ||
| id=ID custom attribute type ID |
There was a problem hiding this comment.
A more common convention of documenting this is to do the following:
name=NAME or ID Name or ID of the Custom Attribute type
This also implies that you would just use name= and then pass in the name and optionally the ID.. This does change the logic a bit
mattpascoe
added a commit
that referenced
this pull request
Mar 16, 2016
Added custom_attribute_type_display dcm module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.