A trial to add type hints for EventBuffer.py and Utils.py
#111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for Python to load type annotations Reason: the class `Anticipation` requires `PredictiveImplication` as a type dependency
…hat is already loaded from context
|
Thank you so much for your interest in event buffers, to which is mainly implemented by me. I am going to give you some feedback tomorrow. Thank you!
Sincerely,
Tangrui
From: Argon ***@***.***>
Date: Thursday, July 25, 2024 at 2:58 AM
To: bowen-xu/PyNARS ***@***.***>
Cc: Tangrui Li ***@***.***>, Mention ***@***.***>
Subject: [External] [bowen-xu/PyNARS] A trial to add type hints for `EventBuffer.py` and `Utils.py` (PR #111)
Intro
Based on the technical report of CAGI 2024 in Nanjing<https://www.bilibili.com/video/BV1Ff421B7sp/?p=3> published by @MoonWalker1997<https://github.com/MoonWalker1997>, I'm interesting to the temporal part of NAL, and want to learn the specific mechanism & concrete implementation of the "Event Buffer"(EB) data structure.
In recent 2 days, I have found the source code of EB on PyNARS, and tried to understand the code in combination with the technical report in CAGI.
Now I think I have a preliminary understanding of EB, althrough it's not yet completely implemented.
Modifications
For all Python classes and functions(or method in a class) in EventBuffer.py and Utils.py, I added the type hints for them assisted by MyPy type checker.
It includes:
* Fields and their types in class
* Function signature of each def (even the def __init__(...) -> None)
* Reorder the class definition of Anticipation to represent its dependence of PredictiveImplication
* Some side comments containing questions or problems that may to be solved
Other Words
I think this PR can be merged after further discussion, adjustment and development as a reference for future learners.
Due to Python's asymptotic type system, it also won't be an obstable the original development.
If I'm not suitable of this work, It can also be a code reference, which is already helped me to learn NAL-7.
…________________________________
You can view, comment on, or merge this pull request online at:
https://github.com/bowen-xu/PyNARS/pull/111
Commit Summary
* 8ac6ec7<bowen-xu/PyNARS@8ac6ec7> refactor(event_buffer): A trial to add type hints for `EventBuffer.py` and `Utils.py`
* ce2b709<bowen-xu/PyNARS@ce2b709> refactor: Adjust the order of class `Anticipation` to make it easier for Python to load type annotations
* 7a28ad8<bowen-xu/PyNARS@7a28ad8> refactor(event_buffer): remove the unnecessary quotes around a type that is already loaded from context
File Changes
(2 files<https://github.com/bowen-xu/PyNARS/pull/111/files>)
* M pynars/NARS/DataStructures/MC/EventBuffer.py<https://github.com/bowen-xu/PyNARS/pull/111/files#diff-b27c9c0288e919a3a35febd20fe477193024b9d3ad0e0b7e392510209ffd5370> (122)
* M pynars/NARS/DataStructures/MC/Utils.py<https://github.com/bowen-xu/PyNARS/pull/111/files#diff-f0e822f5397f41b661b1e0f7db4d083c7e0d7b59cd26e7d787c367e656ecfdc7> (41)
Patch Links:
* https://github.com/bowen-xu/PyNARS/pull/111.patch
* https://github.com/bowen-xu/PyNARS/pull/111.diff
—
Reply to this email directly, view it on GitHub<https://github.com/bowen-xu/PyNARS/pull/111>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANJMW6J7FN2G237MEPLFP7TZOCOXTAVCNFSM6AAAAABLN4SLTCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQZDSMJXG44DGNY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intro
Based on the technical report of CAGI 2024 in Nanjing presented by @MoonWalker1997, I'm interesting to the temporal part of NAL, and want to learn the specific mechanism & concrete implementation of the "Event Buffer"(EB) data structure.
In recent 2 days, I have found the source code of EB on PyNARS, and tried to understand the code in combination with the technical report in CAGI.
Now I think I have a preliminary understanding of EB, althrough it's not yet completely implemented.
Modifications
For all Python classes and functions(or method in a class) in
EventBuffer.pyandUtils.py, I added the type hints for them assisted by MyPy type checker.It includes:
classdef(even thedef __init__(...) -> None)classdefinition ofAnticipationto represent its dependence ofPredictiveImplicationOther Words
I think this PR can be merged after further discussion, adjustment and development as a reference for future learners.
Due to Python's asymptotic type system, it also won't be an obstable the original development.
If I'm not suitable of this work, It can also be a code reference, which is already helped me to learn NAL-7.