Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add decommissioned event type reason to agency vehicle_event schema #408

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Add decommissioned event type reason to agency vehicle_event schema #408

merged 1 commit into from
Feb 26, 2020

Conversation

thekidder
Copy link
Contributor

Explain pull request

The vehicle_event schema file does not include the decommissioned event_type reason added in 0.3.1. This PR ensures the schema matches the spec.

Is this a breaking change

  • No, not breaking

Impacted Spec

Which spec(s) will this pull request impact?

  • agency

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@thekidder
Copy link
Contributor Author

CLA now signed - sorry for the delay!

@sarob sarob added Agency Specific to the Agency API enhancement New feature or request Schema Implications for JSON Schema or OpenAPI labels Dec 19, 2019
@HenriJ HenriJ added this to the 0.4.1 milestone Jan 3, 2020
HenriJ
HenriJ approved these changes Jan 3, 2020
View reviewed changes
Copy link

@HenriJ HenriJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the fix !

@Retzoh
Copy link
Contributor

Retzoh commented Feb 19, 2020

@HenriJ @thekaveman can we merge this PR if it is approved ?

@thekaveman thekaveman merged commit f9b8053 into openmobilityfoundation:dev Feb 26, 2020
thekaveman added a commit that referenced this pull request Mar 1, 2020
@thekaveman
add missing event_type_reason to schema template
93cfea9 
follow-up to #408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

@HenriJ HenriJ HenriJ approved these changes

@hunterowens hunterowens Awaiting requested review from hunterowens

Assignees
No one assigned
Labels
Agency Specific to the Agency API enhancement New feature or request Schema Implications for JSON Schema or OpenAPI
Projects
None yet
Milestone
0.4.1
Development

Successfully merging this pull request may close these issues.
6 participants
@thekidder @CLAassistant @Retzoh @HenriJ @thekaveman @sarob