Add new battery_charged event type reason
#237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the battery of a device is too low, the service yields the `unavailable` event type with the `low_battery` reason. Then the device may charge itself (for example because it has been plugged to a charging dock by the last customer, or because the device has a solar panel). Once the battery is charged enough, the service can yield an `available` event type with the `battery_charged` reason. [closes openmobilityfoundation#210]
bors-ltd
force-pushed
the
bluesystems/battery_charged
branch
from
64c0986
to
d12b774
Compare
marie-x
approved these changes
Feb 20, 2019
|
@dbaty, just to clarify why I asked for a reversion of this PR. I think we need to have a clear way we add an support additional modes to MDS, as there are a number of difference in the core technologies, data we need and legal frameworks to support for different modes. In #95, I propose a directory structure, with the What PR that we have to close #170 should have a how to guide about writing MDS support for different modes. |
|
It's not clear to me how this event is linked to different transport modes. Could they not apply to electric bikes and scooters that are currently supported? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #210.
When the battery of a device is too low, the service yields the
unavailableevent type with thelow_batteryreason. Then thedevice may charge itself (for example because it has been plugged to a
charging dock by the last customer, or because the device has a solar
panel). Once the battery is charged enough, the service can yield an
availableevent type with thebattery_chargedreason.[closes #210]