Updated associated trip patch #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ired if applicable instead of optional
hunterowens
reviewed
Feb 4, 2019
| "available" | ||
| ] | ||
| }, | ||
| "event_type_reason": { |
There was a problem hiding this comment.
@oderby I may be reading this wrong, but shouldn't the only event_type_reasons be user_pick_up and user_drop_off
There was a problem hiding this comment.
Yeah - that's specified at line 375 for the sub-schema restricting when associated_trip is required. Here, this is the sub-schema for valid combinations of event_type and event_type_reason
Closed
hunterowens
approved these changes
Feb 4, 2019
7 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some time, so I fixed up and rebased #202. Same fix, but with json schema fixes (it wasn't actually requiring
associated_trip) and cleanup.