-
Notifications
You must be signed in to change notification settings - Fork 20
Update CI versions #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Why drop CUDA 10.2? |
CUDA 10.2 was dropped by conda-forge (conda-forge/conda-forge-pinning-feedstock#3491) |
That just says the PyTorch maintainers are considering dropping it for future PyTorch builds on conda-forge. That doesn't mean we need to stop testing it. Especially since we're still testing older PyTorch versions that provide CUDA 10.2 builds. |
It was dropped two months ago (conda-forge/nnpops-feedstock@c983beb) |
@RaulPPelaez @sef43 do you see any reason to keep testing on CUDA 10.2? |
I think It seems reasonable to drop |
I believe there is value in leaving old versions there. If and when CUDA 10.2 tests do not pass then we can decide if its worth to do something about it or simply drop it to reduce maintainer burden as pytorch just did. |
OK! Let's keep CUDA 10.2 until it works. |
@peastman @RaulPPelaez @sef43 could you review? |
torch 1.13 resulted in some tests failing, I believe that is not solved yet. |
Keep in mind, CI doesn't run the tests on GPU. |
Oh right. Looks fine to me then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Drop CUDA 10.2