Skip to content

Update CI versions #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 7, 2023
Merged

Update CI versions #88

merged 8 commits into from
Mar 7, 2023

Conversation

raimis
Copy link
Contributor

@raimis raimis commented Mar 3, 2023

  • Add PyTorch 1.13
  • Drop CUDA 10.2
  • Drop Python 3.7
  • Update to Ubuntu 22.04

@raimis raimis self-assigned this Mar 3, 2023
@raimis raimis marked this pull request as ready for review March 3, 2023 16:53
@raimis raimis requested a review from peastman March 3, 2023 16:53
@peastman
Copy link
Member

peastman commented Mar 3, 2023

Why drop CUDA 10.2?

@raimis
Copy link
Contributor Author

raimis commented Mar 3, 2023

CUDA 10.2 was dropped by conda-forge (conda-forge/conda-forge-pinning-feedstock#3491)

@peastman
Copy link
Member

peastman commented Mar 3, 2023

That just says the PyTorch maintainers are considering dropping it for future PyTorch builds on conda-forge. That doesn't mean we need to stop testing it. Especially since we're still testing older PyTorch versions that provide CUDA 10.2 builds.

@raimis
Copy link
Contributor Author

raimis commented Mar 6, 2023

It was dropped two months ago (conda-forge/nnpops-feedstock@c983beb)

@raimis
Copy link
Contributor Author

raimis commented Mar 6, 2023

@RaulPPelaez @sef43 do you see any reason to keep testing on CUDA 10.2?

@sef43
Copy link
Contributor

sef43 commented Mar 6, 2023

@RaulPPelaez @sef43 do you see any reason to keep testing on CUDA 10.2?

I think It seems reasonable to drop

@RaulPPelaez
Copy link
Contributor

I believe there is value in leaving old versions there. If and when CUDA 10.2 tests do not pass then we can decide if its worth to do something about it or simply drop it to reduce maintainer burden as pytorch just did.

@raimis
Copy link
Contributor Author

raimis commented Mar 6, 2023

OK! Let's keep CUDA 10.2 until it works.

@raimis
Copy link
Contributor Author

raimis commented Mar 7, 2023

@peastman @RaulPPelaez @sef43 could you review?

@RaulPPelaez
Copy link
Contributor

@peastman @RaulPPelaez @sef43 could you review?

torch 1.13 resulted in some tests failing, I believe that is not solved yet.

@raimis
Copy link
Contributor Author

raimis commented Mar 7, 2023

Keep in mind, CI doesn't run the tests on GPU.

@RaulPPelaez
Copy link
Contributor

Oh right. Looks fine to me then.

Copy link
Member

@peastman peastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@raimis raimis merged commit c2f0ca0 into openmm:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants