Skip to content

Commit

Permalink
Merge pull request #120 from openmindculture/feature/add-colors
Browse files Browse the repository at this point in the history
Add / fix mismatching colors after UI update (WIP)
  • Loading branch information
openmindculture authored Sep 1, 2023
2 parents cb80b9f + a2a5b9e commit 707bfc7
Show file tree
Hide file tree
Showing 7 changed files with 48 additions and 6 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

# intellij-cute-pink-light-theme Changelog

## 0.9.0 - 2023-08-30
- add missing color definitions for 2023.2

## 0.8.4 - 2023-07-31
### Fixed
- Extend future compatibility beyond 2023.2 (232)
Expand Down
21 changes: 19 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,21 @@ wizard for creating a UI theme. See:
- https://blog.jetbrains.com/platform/2021/10/themes-in-intellij-based-ides/
- https://plugins.jetbrains.com/docs/intellij/theme-structure.html

To find out the internal names of UI elements, we can now use the [UI inspector](https://blog.jetbrains.com/platform/2021/10/themes-in-intellij-based-ides/#UI_Inspector%EF%BB%BF).
To find out the internal names of UI elements, we can now use the [UI inspector](https://blog.jetbrains.com/platform/2021/10/themes-in-intellij-based-ides/#UI_Inspector%EF%BB%BF):
> The UI Inspector is a powerful tool to investigate the IntelliJ-based IDE UI elements to get an internal description of each element. In addition, UI elements can be tested interactively with Ctrl+Alt+Click on the element.
>
> Before using the UI Inspector, it must be enabled by selecting the menu item Tools | Internal Actions | UI | UI Inspector. The enabled state of the UI Inspector is modal; it remains enabled until it is disabled by selecting the menu item again.
>
> If the menu item Tools | Internal Actions is not available in IntelliJ IDEA, then the first step is [Enabling Internal Mode](https://plugins.jetbrains.com/docs/intellij/enabling-internal.html):
>
> From the main menu, select Help | Edit Custom Properties... This selection opens IntelliJ IDEA's idea.properties file. If it does not exist, IntelliJ IDEA will prompt to create one.
>
> Add the line shown below to the idea.properties file:
>
> `idea.is.internal=true`
> Save the idea.properties file and restart IntelliJ IDEA.
More information about colors and fonts can be found here: https://www.jetbrains.com/help/idea/configuring-colors-and-fonts.html

### Development, Build and Export

Expand Down Expand Up @@ -81,7 +95,7 @@ Create an archive `intellij-cute-pink-light-theme-x.y.z.zip` containing:
- `intellij-cute-pink-light-theme/`
- `lib/`
- `intellij-cute-pink-light-theme-x.y.z.jar`
The `.jar` file is another zip archive containing the contents of `src/resources`
The `.jar` file is another zip archive containing the contents of `src/main/resources`
with **no additional folder in between, e.g.:
- `cute_pink_light.theme.json`
- `cute_pink_light.xml`
Expand All @@ -92,6 +106,9 @@ Create an archive `intellij-cute-pink-light-theme-x.y.z.zip` containing:

A valid `MANIFEST.MF` example is included to simplify theme export and update.

You can use the build script `./build.sh $version` to build, e.g.
`./build.sh 2.9.0`

#### Fix Problems and Incompatibilities

If the build does not run anymore, try to
Expand Down
12 changes: 12 additions & 0 deletions build.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
mkdir build/intellij-cute-pink-light-theme
rm -rf build/intellij-cute-pink-light-theme/*
mkdir build/intellij-cute-pink-light-theme/lib
mkdir build/intellij-cute-pink-light-theme-$1
cp -r src/main/resources/* build/intellij-cute-pink-light-theme-$1/
cd build
cd intellij-cute-pink-light-theme-$1
zip -r ../intellij-cute-pink-light-theme/lib/intellij-cute-pink-light-theme-$1.jar ./*
cd ..
zip -r distributions/intellij-cute-pink-light-theme-$1.zip.tmp intellij-cute-pink-light-theme
rm -f distributions/intellij-cute-pink-light-theme-$1.zip
mv distributions/intellij-cute-pink-light-theme-$1.zip.tmp distributions/intellij-cute-pink-light-theme-$1.zip
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
pluginGroup = com.github.openmindculture.intellijcutepinklighttheme
pluginName = intellij-cute-pink-light-theme

pluginVersion = 0.8.4
pluginVersion = 0.9.0
pluginSinceBuild = 202
# Plugin Verifier integration -> https://github.com/JetBrains/gradle-intellij-plugin#plugin-verifier-dsl
# See https://jb.gg/intellij-platform-builds-list for available build versions
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/META-INF/MANIFEST.MF
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Manifest-Version: 1.0
Created-By: Gradle 7.5.0
Build-JVM: 17.0.4.1 (JetBrains s.r.o. 17.0.4.1+7-b469.62)
Version: 0.8.4
Version: 0.9.0
Build-Plugin: Gradle IntelliJ Plugin
Build-Plugin-Version: 1.10.0
Build-OS: Linux 6.2.0-10018-tuxedo amd64
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/META-INF/plugin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<id>com.github.openmindculture.intellijcutepinklighttheme</id>
<description>Cute Pink Light Theme for IntelliJ Platform inspired by WebFreak's Cute Pink Light Theme for VisualStudio Code.</description>
<change-notes>Initial theme release. Basic theme functionality.</change-notes>
<version>0.8.4</version>
<version>0.9.0</version>
<vendor url="https://github.com/openmindculture/">Ingo Steinke (openmindculture)</vendor>

<!-- Compatible with the following versions of IntelliJ Platform:
Expand Down
12 changes: 11 additions & 1 deletion src/main/resources/cute_pink_light.theme.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,16 @@
"Borders": {
"color": "whiteBg",
"ContrastBorderColor": "purpleRedBorder"
}
},
"Panel.foreground": "purpleDarkText",
"Panel.foreground.hover": "purpleDarkText",
"Panel.hoverForeground": "purpleDarkText",
"ScrollPane.background": "whiteBg",
"ScrollPane.foreground": "purpleDarkText",
"TextArea.foreground": "purpleDarkText",
"TextField.background": "whiteBg",
"TextField.foreground": "purpleDarkText",
"TextField.inactiveForeground": "purpleDarkText",
"Viewport.foreground": "purpleDarkText"
}
}

0 comments on commit 707bfc7

Please sign in to comment.