fix: do not hardcode schema in migrations

[turip]

Overview

If the openmeter is put into a different schema, then hardcoding the public causes issues.

Fixes #3150

Given that we are only storing the migration version in the schema table, this change would only affect deployments that are on db schema versions earlier than the updated migration.

Summary by CodeRabbit

• Chores
  • Updated database migration scripts to remove explicit schema prefixes from table references.

[coderabbitai]

📝 Walkthrough

Walkthrough

The migration SQL script was updated to remove the explicit public. schema prefix from all table references, standardizing them to unqualified table names. The underlying logic and structure of the migration queries remain unchanged.

Changes

Cohort / File(s)	Change Summary
Schema Prefix Removal in Migration Script tools/migrate/migrations/20250609204117_billing-migrate-split-line-groups.up.sql	Removed public. schema prefix from all table references in SQL statements; query logic unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3528165 and 33425dc.

⛔ Files ignored due to path filters (1)

• tools/migrate/migrations/atlas.sum is excluded by !**/*.sum

📒 Files selected for processing (1)

• tools/migrate/migrations/20250609204117_billing-migrate-split-line-groups.up.sql (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)

• GitHub Check: Artifacts / Benthos Collector Container image
• GitHub Check: CI
• GitHub Check: E2E
• GitHub Check: Migration Checks
• GitHub Check: Build
• GitHub Check: Developer environment
• GitHub Check: Commit hooks
• GitHub Check: Test
• GitHub Check: Quickstart
• GitHub Check: Lint
• GitHub Check: Analyze (go)
• GitHub Check: Analyze (javascript)

🔇 Additional comments (1)

tools/migrate/migrations/20250609204117_billing-migrate-split-line-groups.up.sql (1)

4-25: Ensure migrations run in the intended schema by setting search_path

The DML in tools/migrate/migrations/20250609204117_billing-migrate-split-line-groups.up.sql (no explicit public. prefix) will target whatever Postgres’ search_path is at runtime. The migrate runner (see Up() in tools/migrate/migrate.go) does not itself set search_path, nor does it inject a schema parameter into the connection string.

Please confirm one of the following before merging:

• The caller’s connection string includes a search_path= parameter (so migrations can only write to that schema).
• You add an explicit schema pin at the top of this migration (and any similar files, e.g. lines 47, 53–56, 59–60):

SET LOCAL search_path = <schema_name>, pg_catalog;

This will guard against accidental writes to public if your runner ever uses the default path.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/do-not-hardcode-schema-in-migrations

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.