chore: fix test notification event

[turip]

Overview

We are now using usage based lines to wrap flat fee lines. This patch makes sure that the test payload is adjusted accordingly.

Summary by CodeRabbit

• Bug Fixes

  • Improved stability by preventing errors when processing usage-based billing lines in invoices.

• Refactor

  • Updated the billing line item in invoice payload generation to use a usage-based flat fee approach instead of a standard flat fee. No changes to user-facing functionality.

[coderabbitai]

📝 Walkthrough

Walkthrough

The change updates the construction of billing line items in the test invoice payload generator, switching from using a flat fee billing line to a usage-based flat fee billing line. Additionally, it adds a nil check for the UsageBased field in invoice line mapping to prevent potential nil pointer dereferences.

Changes

Files	Change Summary
openmeter/notification/internal/rule.go	Replaces creation of flat fee billing lines with usage-based flat fee billing lines in test invoice payload generation.
openmeter/billing/httpdriver/invoiceline.go	Adds nil check for UsageBased field in mapInvoiceLineToAPI to avoid nil pointer dereference.

Possibly related PRs

• feat: use UBP flat fee lines #2898: Introduces support and feature-flagged handling for usage-based flat fee lines in billing synchronization and helpers.
• fix: flat fee line do not validate meter #2908: Modifies validation logic specifically for usage-based flat fee lines, directly relating to the updated billing line type.
• fix: invoice line updates #2932: Fixes invoice line updates by correcting line types and preparing usage-based flat fee lines for creation, closely related to the billing line type change.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7388c70 and 0f1e470.

📒 Files selected for processing (1)

• openmeter/billing/httpdriver/invoiceline.go (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: chrisgacsal
PR: openmeterio/openmeter#2699
File: openmeter/productcatalog/planaddon/service/service_test.go:210-211
Timestamp: 2025-04-21T08:32:31.689Z
Learning: In `productcatalog.UsageBasedRateCard`, the `BillingCadence` field is a non-pointer `isodate.Period`, while in `productcatalog.FlatFeeRateCard`, `BillingCadence` is a pointer type (`*isodate.Period`). This means `MonthPeriod` should be used directly for `UsageBasedRateCard` (not `&MonthPeriod`).

openmeter/billing/httpdriver/invoiceline.go (1)

Learnt from: chrisgacsal
PR: openmeterio/openmeter#2699
File: openmeter/productcatalog/planaddon/service/service_test.go:210-211
Timestamp: 2025-04-21T08:32:31.689Z
Learning: In `productcatalog.UsageBasedRateCard`, the `BillingCadence` field is a non-pointer `isodate.Period`, while in `productcatalog.FlatFeeRateCard`, `BillingCadence` is a pointer type (`*isodate.Period`). This means `MonthPeriod` should be used directly for `UsageBasedRateCard` (not `&MonthPeriod`).

🧬 Code Graph Analysis (1)

openmeter/billing/httpdriver/invoiceline.go (1)

api/api.gen.go (1)

• InvoiceLine (3619-3725)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

• GitHub Check: E2E
• GitHub Check: Commit hooks
• GitHub Check: Quickstart
• GitHub Check: CI
• GitHub Check: Developer environment
• GitHub Check: Lint
• GitHub Check: Test
• GitHub Check: Build
• GitHub Check: Migration Checks
• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (go)

🔇 Additional comments (1)

openmeter/billing/httpdriver/invoiceline.go (1)

279-281: Good defensive programming practice!

The nil check for line.UsageBased before accessing its fields prevents potential nil pointer dereferences. This is particularly important given the context of wrapping flat fee lines with usage-based lines, where the UsageBased field might be nil in certain scenarios. The error message follows the existing pattern and includes the line ID for effective debugging.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.