fix: flat price term defaulting

[turip]

Overview

Fix issue when flat price's paymentTerm is unset. We are now properly using the default inAdvance behavior.

Summary by CodeRabbit

• Bug Fixes
  • Ensured that the payment term for flat pricing is automatically set to a default value if not provided, improving consistency in billing behavior.

[coderabbitai]

📝 Walkthrough

Walkthrough

A conditional check is introduced to set a default payment term in flat price objects when the PaymentTerm field is empty, using a value from the product catalog. This change ensures that payment term validation logic always operates on a non-empty value. No other logic or error handling is modified.

Changes

Files	Change Summary
openmeter/billing/service/lineservice/priceflat.go	Added logic to assign a default payment term from the product catalog if the field is empty.

Possibly related PRs

• fix: invoice line updates #2932: Modifies PrepareForCreate to set a default payment term if missing, similar to this PR's handling of payment terms in flat price lines.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2
Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ab34cc8 and 5506e54.

📒 Files selected for processing (1)

• openmeter/billing/service/lineservice/priceflat.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (10)

• GitHub Check: Developer environment
• GitHub Check: Commit hooks
• GitHub Check: CI
• GitHub Check: Quickstart
• GitHub Check: Lint
• GitHub Check: E2E
• GitHub Check: Migration Checks
• GitHub Check: Build
• GitHub Check: Test
• GitHub Check: Analyze (go)

🔇 Additional comments (1)

openmeter/billing/service/lineservice/priceflat.go (1)

26-28:

Details

✅ Verification successful

Good fix for handling empty payment terms!

The conditional check appropriately sets a default payment term when none is provided, ensuring the subsequent validation logic always operates on a non-empty value. The placement between price conversion and validation is ideal.

Please verify that productcatalog.DefaultPaymentTerm is set to one of the supported payment term types (InAdvancePaymentTerm or InArrearsPaymentTerm) to ensure it passes the validation check on lines 30-36.

---

🏁 Script executed:

#!/bin/bash
# Description: Verify that DefaultPaymentTerm is set to a supported value
# Expected: DefaultPaymentTerm should be either InAdvancePaymentTerm or InArrearsPaymentTerm

# Search for the definition of DefaultPaymentTerm
rg -A 3 -B 3 "DefaultPaymentTerm.*=" 

# Search for the supported payment term constants
rg -A 2 -B 2 "(InAdvancePaymentTerm|InArrearsPaymentTerm).*="

Length of output: 1683

---

DefaultPaymentTerm passes validation

Verified that productcatalog.DefaultPaymentTerm is defined as InAdvancePaymentTerm, which matches one of the supported values (InAdvancePaymentTerm or InArrearsPaymentTerm). No further changes needed.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.