-
Notifications
You must be signed in to change notification settings - Fork 598
Implement surface flux tallies #3742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
The tests does not pass because of #3743. |
|
This PR is ready for review. |
|
Thanks for the PR @GuySten! I'm wondering what your thoughts are on providing the Given that the score requires a tally have a Let me know what you think! |
|
If I remember correctly there is a case when there are only CellFrom and Cell filters without surface filters. I think if there is interest we can add in a subsequent PR attributes to the Surface objects themselves that will override the defaults in the setting object. |
Ah, yes, right you are. Part of the motivation for my comment was that we avoid additional global settings, but in light of the |
|
Haven't forgotten about this. Will give it another look tomorrow |
Description
This PR enable openmc to calculate surface flux tallies.
Fixes #2.
Theory
https://www.tandfonline.com/doi/pdf/10.13182/NSE09-72
Checklist