Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading of horizontal field of view for ray-traced plots #3330

Merged
merged 4 commits into from
Feb 28, 2025

Conversation

paulromano
Copy link
Contributor

Description

I noticed that RayTracePlot writes the horizontal field of view to the <horizontal_field_of_view> element in the XML file, but the C++ side was not checking the right name. This PR fixes that and also updates the docstrings for the WireframeRayTracePlot and SolidRayTracePlot classes to include all attributes that can be set.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

Copy link
Contributor

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @paulromano!

@pshriwise pshriwise enabled auto-merge (squash) February 28, 2025 15:32
Copy link
Contributor

@gridley gridley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, sorry about that!

@pshriwise pshriwise merged commit 39ad29d into openmc-dev:develop Feb 28, 2025
15 checks passed
@paulromano paulromano deleted the raytraceplot-fixes branch March 4, 2025 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants