Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify effect of CMAKE_BUILD_TYPE in docs #3321

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

paulromano
Copy link
Contributor

Description

This PR clarifies the use of CMAKE_BUILD_TYPE with respect to what compiler flags are typically (but not always) used.

Fixes #3314.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@paulromano paulromano requested a review from yardasol February 24, 2025 16:02
Copy link
Contributor

@yardasol yardasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good clarification @paulromano

@yardasol yardasol enabled auto-merge (squash) February 24, 2025 17:39
@yardasol yardasol merged commit 244d630 into openmc-dev:develop Feb 24, 2025
15 checks passed
@paulromano paulromano deleted the clarify-docs-optimization branch February 25, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMAKE_BUILD_TYPE=Debug uses -O2 optimization instead of -O0
2 participants