Add a composite surface called vessel, which includes a 'ZCylinder' with ellipsoids on top and bottom. #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith ellipsoids on top and bottom.
pshriwise
requested changes
Oct 15, 2024
There was a problem hiding this comment.
Thanks @nsedayilmaz! This is a nice addition and great application for the composite surface. I've made a few small comments here. We'll want to add some tests for this surface as well.
| """Vessel as a composite surface parallel to z-axis | ||
| includes composite surfaces with a ZCylinder and | ||
| semi-ellipsoids on top and the bottom of this cylinder. | ||
| """ |
There was a problem hiding this comment.
We'll want to include some parameter descriptions in the documentation string here.
Co-authored-by: Patrick Shriwise <pshriwise@gmail.com>
Co-authored-by: Patrick Shriwise <pshriwise@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.