-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wheel building with scikit build core #3087
base: develop
Are you sure you want to change the base?
Conversation
for anyone interested in wheels that contain DAGMC, Double Down, Embree and Moab options in the OpenMC executable then I have that working on this branch, clone or checkout that branch |
just to note a new pip version is needed to pass in cmake arguments via the command line, if you get this error then upgrade pip (I'm using version 24.1.2)
solve with
|
nice the docs on readthedocs are now working, it needed a bit of tweaking as they now installing the package with this scikit build core method. |
@@ -1,2 +1,2 @@ | |||
k-combined: | |||
1.716873E+00 5.266107E-02 | |||
1.716873E+00 5.266094E-02 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shimwell, is this one added unintentionally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was seeing small changes to the regression test values in the CI so I changed this value to see if that helped. Perhaps this is no longer necessary. Ideally this change would not be need and we would keep the values the same as the original.
Only one test is failing, stating that data/compton_profiles.h5 is not found. I tested this on my machine, and it was working. I'm not sure why sdist is not including it. |
58c8f26
to
d1f8ae3
Compare
I've solved the merge conflicts and kept this upto date with develop |
Description
Just making this PR to show a bit of progress with the production of wheels using scikit build core. Tagging @hassec as he made the
OpenMCExtension
part of this PR.Running
pip install .
in the root folder of this repo and this will compile openmc and build a wheel and then install the python package and openmc executable from the wheel with default cmake args.It is also possible to pass in cmake args via the command line in the same line as the pip install command.
you can also run
pip install . --no-clean
This will do the same but it won't delete the wheel afterwards. This allows you to inspect the wheel and manually install from the wheel. The path to the wheel is printed to the terminal and will be in your /tmp folderI've added some
if(SKBUILD)
statements to the CMakeLists.txt to help insure the new commands only run if the process is being driven by Scikit build core and therefore this preserves the current behavior when someone wants to build the executable with cmakeI can follow up this PR to include ciwheelbuilder to make wheels for different OS versions
Fixes # (issue)
Checklist