-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use temperature bounds in multigroup mode temperature #3059
base: develop
Are you sure you want to change the base?
Conversation
@meltawila can you check your Cardinal simulation against this newer OpenMC branch? You'll want to do
and then try running your models to see if this picks up the temperature range correctly. |
src/mgxs.cpp
Outdated
@@ -95,6 +95,32 @@ void Mgxs::metadata_from_hdf5(hid_t xs_id, const vector<double>& temperature, | |||
settings::temperature_method = TemperatureMethod::NEAREST; | |||
} | |||
|
|||
// Determine actual temperatures to read -- start by checking whether a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a place in OpenMC to place this which can allow us to consolidate this code and the identical lines from nuclide.cpp
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like a util header? I'm not sure which one, maybe if there is one for std::vector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could put a utility function in settings.h
that sets temps_to_read
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with any luck we might be able to include from line 98 to 178 in this utility. @meltawila do you want to give it a try?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gave it a shot
3d707b1
to
5c4ce11
Compare
822c9cc
to
8d74059
Compare
… reading temperatures
refs #2402
@meltawila
Checklist
For the last item, I'm moving code from a file to another so I should be fine, the code will still be covered by existing testing