Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix R < r torus intersection bug #2589

Merged
merged 3 commits into from
Jul 14, 2023
Merged

Commits on Jul 5, 2023

  1. Fix R < r torus intersection bug

    In the case when R < r the inner "imaginary" surfaces created an additional source of scattering close to the center of the torus. This error occurred due to the lack of a check in the solution of the torus equation. If we
    describe the equation in more detail, we obtain the following: . We see that the left part should obviously be less than or equal to zero. This check was missing in the code of surface.cpp file and was added in lines 972-978.
    egor1abs committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    b914317 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Update src/surface.cpp

    Thanks! It is a better way to perform this check
    
    Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
    egor1abs and paulromano authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    fded109 View commit details
    Browse the repository at this point in the history
  2. Update src/surface.cpp

    paulromano authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    f974335 View commit details
    Browse the repository at this point in the history