Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cylindrical prism with optional filleted edges #2309

Merged
merged 26 commits into from
Jul 18, 2023
Merged

Cylindrical prism with optional filleted edges #2309

merged 26 commits into from
Jul 18, 2023

Commits on Nov 23, 2022

  1. add cylindrical_prism function

    @yardasol
    yardasol committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    033ecb0 View commit details
    Browse the repository at this point in the history

  2. Add unit test for cylindrical_prism

    @yardasol
    yardasol committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    55abbd3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into rounded-cyl-corners

    @yardasol
    yardasol authored Nov 23, 2022
    Configuration menu
    Copy the full SHA
    2409d0e View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Apply @paulromano 's suggestions from code review 

    Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
    @yardasol @paulromano
    yardasol and paulromano authored Dec 8, 2022
    Configuration menu
    Copy the full SHA
    69d2bb5 View commit details
    Browse the repository at this point in the history

  2. add fillet terminology

    @yardasol
    yardasol committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    f0d55e3 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/rounded-cyl-corners' into rounde… 

    …d-cyl-corners
    @yardasol
    yardasol committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    56be597 View commit details
    Browse the repository at this point in the history

  4. Apply @pshriwise suggestions from code review 

    typo fix in comment

Co-authored-by: Patrick Shriwise <pshriwise@gmail.com>
    @yardasol @pshriwise
    yardasol and pshriwise authored Dec 8, 2022
    Configuration menu
    Copy the full SHA
    0236e4b View commit details
    Browse the repository at this point in the history

  5. pep8 fixes

    @yardasol
    yardasol committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    f77f6c1 View commit details
    Browse the repository at this point in the history

  6. fix return string

    @yardasol
    yardasol committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    e3c573b View commit details
    Browse the repository at this point in the history

  7. rewrite test_cyl_prism()

    @yardasol
    yardasol committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    2fa0c96 View commit details
    Browse the repository at this point in the history

  8. add helper function to reduce code reuse

    @yardasol
    yardasol committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    974c706 View commit details
    Browse the repository at this point in the history

  9. Add cylindrical_prism() to the API docs

    @yardasol
    yardasol committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    6ca6f4d View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. Use @gonuke's suggestion for simplifying create_fillet() 

    Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>
    @yardasol @gonuke
    yardasol and gonuke committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    e1d27a9 View commit details
    Browse the repository at this point in the history

  2. make use of getattr consistent; use shared _plane function

    @yardasol
    yardasol committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    c767ea3 View commit details
    Browse the repository at this point in the history

  3. fillet_upper -> upper_fillet; fillet_lower -> lower_fillet

    @yardasol
    yardasol committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    3e24dcd View commit details
    Browse the repository at this point in the history

  4. cleanup create_fillet()

    @yardasol
    yardasol committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    8dc3983 View commit details
    Browse the repository at this point in the history

  5. Add @pshriwise's input for the unit test

    @yardasol
    yardasol committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    052b5c2 View commit details
    Browse the repository at this point in the history

  6. fix unit test

    @yardasol
    yardasol committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    24432ea View commit details
    Browse the repository at this point in the history

  7. simplify import statements

    @yardasol
    yardasol committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    11ab97f View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2023

  1. move fillet functionality to RightCircularCylinder

    @yardasol
    yardasol committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    84d35a7 View commit details
    Browse the repository at this point in the history

  2. add additional surfaces to docstring

    @yardasol
    yardasol committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    896bb1c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into rounded-cyl-corners

    @yardasol
    yardasol authored Jun 11, 2023
    Configuration menu
    Copy the full SHA
    26a21eb View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. cleanup

    @yardasol
    yardasol authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    c28ef4a View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. typo fix

    @yardasol
    yardasol committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    a1f3071 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Merge remote-tracking branch 'upstream/develop' into rounded-cyl-corners

    @yardasol
    yardasol committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    2023006 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Apply suggestions from @paulromano code review 

    Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
    @yardasol @paulromano
    yardasol and paulromano committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    e9cb99c View commit details
    Browse the repository at this point in the history