Skip to content

Conversation

@paulromano
Copy link
Contributor

This PR updates GitHub Actions to use Ubuntu 20.04 for our CI tests. Currently, we are using Ubuntu 16.04 which is officially EOL this month, after which it's not clear how long it's going to supported on CI platforms.

In order to get tests working on Ubuntu 16.04, I had to switch our MPI implementation from OpenMPI to MPICH. We actually just switched to OpenMPI in #1820, but it looks like it's not going to work on Ubuntu 20.04. The problem is that recent versions of OpenMPI do not allow recursive invocations of MPI_Init, and this actually happens in our test suite from the following logic:

import subprocess
from mpi4py import MPI

subprocess.run(['mpiexec', '-n', ...])

Importing mpi4py actually initializes MPI in the current process, and then calling a subprocess with mpiexec does it again. MPICH thankfully handles this fine.

There's also a few fixes in here for warnings that are raised when the test suite is run.

Copy link
Contributor

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments from me. Thanks for heading off this issue, @paulromano!

@pshriwise pshriwise merged commit a76c5a7 into openmc-dev:develop Apr 28, 2021
@paulromano paulromano deleted the gha-ubuntu-20-04 branch April 28, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants