Reset particle coordinates in neighbor_list_find_cell
#1809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, sorry to introduce this regression. Good thing the test is in place now! I had taken those lines out because they appeared to not influence correctness, judging from the results of regression tests. |
gridley
approved these changes
Apr 1, 2021
pshriwise
pushed a commit
to pshriwise/openmc
that referenced
this pull request
Apr 24, 2021
Fix segfault from unreset particle coordinates in `neighbor_list_find_cell`
pshriwise
pushed a commit
to pshriwise/openmc
that referenced
this pull request
Apr 24, 2021
Fix segfault from unreset particle coordinates in `neighbor_list_find_cell`
pshriwise
pushed a commit
to pshriwise/openmc
that referenced
this pull request
Apr 24, 2021
Fix segfault from unreset particle coordinates in `neighbor_list_find_cell`
pshriwise
pushed a commit
to pshriwise/openmc
that referenced
this pull request
Apr 26, 2021
Fix segfault from unreset particle coordinates in `neighbor_list_find_cell`
paulromano
pushed a commit
that referenced
this pull request
Apr 26, 2021
Fix segfault from unreset particle coordinates in `neighbor_list_find_cell`
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered today that particles moving from a rotated to an unrotated cell cause a seg fault because the
LocalCoord::rotatedproperty isn't updated correctly. I originally updated theLocalCoords::rotatemethod to always update this property infind_cell_innder, but I think it's best to ensure that the lower level coordinates always get reset inneighbor_list_find_cellin case there are other properties ofLocalCoordthat might cause problems if they aren't updated.I've added a test that fails for this reason (failing CI run in my fork) and added a loop that resets the particle's lower level coordinates in
neighbor_list_find_cellto fix the problem.