Skip to content

Conversation

ashiskumarnaik
Copy link
Contributor

incorporating facts on the use of COBOL on today's era from OMP CWG's survey

Proposed changes

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context to communicate to the maintainers why we should accept this pull request.

Fixes # (##263)

Type of change

What type of changes does your PR introduce to the COBOL Programming Course? Put an x in the boxes that apply.

  • Bug fix (change which fixes one or more issues)
  • New feature (change which adds functionality or features to the course)
  • Translations (change which adds or modifies translations of the course)
  • Documentation (change which modifies documentation related to the course)
  • This change requires an update to the course's z/OS environment

Checklist:

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the Contributing Guideline
  • I have included a title and description for this PR
  • I have DCO-signed all of my commits that are included in this PR
  • I have tested it manually and there are no regressions found
  • I have commented my code, particularly in hard-to-understand areas (if appropriate)
  • I have made corresponding changes to the documentation (if appropriate)

Copy link
Member

@tanto259 tanto259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ashis, thanks for your PR! Left some comments to fix some grammar stuff and also make it clear what OMP CWG is.

@ashiskumarnaik
Copy link
Contributor Author

ashiskumarnaik commented May 29, 2023

@tanto259 I have made the necessary changes . Please review it.

@ashiskumarnaik ashiskumarnaik requested a review from tanto259 May 30, 2023 08:04
Copy link
Member

@tanto259 tanto259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than removing "OMP CWG" for possible confusion (especially since the COBOL Working Group was never shorten as CWG in publications), I have no other feedback. Thanks, Ashis!

… survey

Signed-off-by: Ashis Kumar Naik <ashishami2002@gmail.com>
@ashiskumarnaik ashiskumarnaik requested a review from tanto259 May 30, 2023 12:00
Copy link
Member

@tanto259 tanto259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks, Ashis!

@tanto259 tanto259 merged commit 1cb32cf into openmainframeproject:master May 30, 2023
@tanto259 tanto259 added the enhancement New feature or request label May 30, 2023
@tanto259 tanto259 linked an issue May 30, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update course with survey result from COBOL WG
2 participants