Skip to content

Conversation

vargajb
Copy link
Contributor

@vargajb vargajb commented Oct 17, 2022

Proposed changes

  • Add missing NOTIFY statement:
    Without NOTIFY statement the user won't get notification, when the job completes execution.

  • Add CODEPAGE parameter to avoid waring:
    If codepage is not given for COBOL SQL compiler, then the following warning message is issued:
    "IGYOS4078-W DSNH4791I DSNHPSRV CCSID 1140 IS USED TO PROCESS SQL, BUT DSNHDECP HAS EBCDIC CCSID 1047 IN EFFECT"

  • Since we already use the 88-level conditional data names to detect the end of a loop, therefore we should use them for assignments as well.

Type of change

What type of changes does your PR introduce to the COBOL Programming Course? Put an x in the boxes that apply.

  • Bug fix (change which fixes one or more issues)
  • New feature (change which adds functionality or features to the course)
  • Translations (change which adds or modifies translations of the course)
  • Documentation (change which modifies documentation related to the course)
  • This change requires an update to the course's z/OS environment

Checklist:

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the Contributing Guideline
  • I have included a title and description for this PR
  • I have DCO-signed all of my commits that are included in this PR
  • I have tested it manually and there are no regressions found
  • I have commented my code, particularly in hard-to-understand areas (if appropriate)
  • I have made corresponding changes to the documentation (if appropriate)

Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
@vargajb vargajb changed the title Add CODEPAGE parameter to avoid waring and add missing NOTIFY statement Add CODEPAGE parameter to avoid waring; add missing NOTIFY statement; use 88-level conditional names for assignments Oct 17, 2022
Copy link
Member

@tanto259 tanto259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@tanto259 tanto259 merged commit 91a73c5 into openmainframeproject:master Oct 18, 2022
@tanto259 tanto259 added the enhancement New feature or request label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants