Add CODEPAGE parameter to avoid waring; add missing NOTIFY statement; use 88-level conditional names for assignments #277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add missing NOTIFY statement:
Without NOTIFY statement the user won't get notification, when the job completes execution.
Add CODEPAGE parameter to avoid waring:
If codepage is not given for COBOL SQL compiler, then the following warning message is issued:
"IGYOS4078-W DSNH4791I DSNHPSRV CCSID 1140 IS USED TO PROCESS SQL, BUT DSNHDECP HAS EBCDIC CCSID 1047 IN EFFECT"
Since we already use the 88-level conditional data names to detect the end of a loop, therefore we should use them for assignments as well.
Type of change
What type of changes does your PR introduce to the COBOL Programming Course? Put an
x
in the boxes that apply.Checklist:
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer