Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure data is available for finding exchange rates #58

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

joemull
Copy link
Member

@joemull joemull commented Mar 14, 2024

These changes implement currency region not country as the basis of exchange rates. This was planned but not yet implemented. It doesn't change resulting rates, it just moves from a deprecated source to a more trustworthy one.

Closes #56

Copy link
Member

@mauromsl mauromsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of comments/questions but otherwise good to merge

tests/test_models.py Outdated Show resolved Hide resolved
logic.py Outdated Show resolved Hide resolved
@joemull joemull requested review from mauromsl and removed request for StephDriver March 20, 2024 11:52
Copy link
Member

@mauromsl mauromsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, one last optional comment

Copy link

@StephDriver StephDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logical, but details are beyond me.

@joemull joemull merged commit 98ede91 into master Mar 22, 2024
@joemull joemull deleted the 56-currency-region branch March 22, 2024 11:46
Copy link

@StephDriver StephDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok.

@joemull joemull added this to the Biller UX milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exchange rates should depend on currency region data, not country data
4 participants